[https://nvbugs/6341070][fix] Fix scaffolding MajorityVoteController output handling#15925
Open
KleinBlueC wants to merge 2 commits into
Open
[https://nvbugs/6341070][fix] Fix scaffolding MajorityVoteController output handling#15925KleinBlueC wants to merge 2 commits into
KleinBlueC wants to merge 2 commits into
Conversation
GenerationTask no longer has a `result` field; its output is stored in `output_str`/`output_tokens`. Update the majority-vote result copy to use `output_str`, fixing test_majority_vote. Signed-off-by: kleinc <kleinc@nvidia.com>
…eController fix Remove the _SCAFFOLDING_EXECUTOR_NVBUG skip marker now that the underlying AttributeError in MajorityVoteController.process is fixed. Verified passing: test_unbatched_scaffolding_sync, test_batched_scaffolding_sync, test_async_scaffolding_generation, test_majority_vote, and test_trtllm_worker_generation. Signed-off-by: kleinc <kleinc@nvidia.com>
Author
|
/bot run --disable-fail-fast |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR changes ChangesMajority vote output fix and test re-enablement
Estimated code review effort: 1 (Trivial) | ~5 minutes Related PRs: None identified. Suggested labels: test, bug fix Suggested reviewers: None identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
PR_Github #57466 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #57466 [ run ] completed with state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.